codex: allow-list --profile by subcommand; omit it where codex rejects it#184
Open
Edwinhe03 wants to merge 1 commit into
Open
codex: allow-list --profile by subcommand; omit it where codex rejects it#184Edwinhe03 wants to merge 1 commit into
Edwinhe03 wants to merge 1 commit into
Conversation
Edwinhe03
changed the title
Edwinhe03
force-pushed
the
edwin-he/ucode-composable-flag-injection
branch
from
c577f42 to
bcff2ab
Compare
Edwinhe03
changed the title
Edwinhe03
force-pushed
the
edwin-he/ucode-composable-flag-injection
branch
from
bcff2ab to
7d540fb
Compare
Collaborator
|
am i testing this right? it seems to error on start? i checked out your branch no app-server: with app-server |
Collaborator
|
Collaborator
|
follow up: |
Edwinhe03
changed the title
Edwinhe03
force-pushed
the
edwin-he/ucode-composable-flag-injection
branch
from
7d540fb to
a9961a2
Compare
…s it ucode's codex launch always ran `codex --profile ucode <args>`, but codex only accepts the global `--profile` on runtime subcommands (the interactive TUI, exec/review/resume/archive/delete/unarchive/fork/mcp/sandbox). Server-family subcommands (app-server, mcp-server, exec-server, remote-control) and utilities reject it up front: Error: --profile only applies to runtime commands and `codex mcp`: ... so e.g. `ucode codex app-server` was functionally broken. Allow-list the subcommands that accept `--profile` (a deny-list would break the next codex server subcommand by default) and attach it only for those. For the rest, omit `--profile` and pass the caller's args through untouched — those subcommands are caller-configured (e.g. omnigent runs `codex app-server` with its own CODEX_HOME), so ucode just stays out of the way. Co-authored-by: Isaac
Edwinhe03
changed the title
Edwinhe03
force-pushed
the
edwin-he/ucode-composable-flag-injection
branch
from
a9961a2 to
b37ab3d
Compare
lilly-luo
reviewed
Jul 10, 2026
Comment on lines
+398
to
+421
| _CODEX_GLOBAL_VALUE_FLAGS = frozenset( | ||
| { | ||
| "-c", | ||
| "--config", | ||
| "-i", | ||
| "--image", | ||
| "-m", | ||
| "--model", | ||
| "-p", | ||
| "--profile", | ||
| "-s", | ||
| "--sandbox", | ||
| "-C", | ||
| "--cd", | ||
| "-a", | ||
| "--ask-for-approval", | ||
| "--enable", | ||
| "--disable", | ||
| "--remote", | ||
| "--remote-auth-token-env", | ||
| "--local-provider", | ||
| "--add-dir", | ||
| } | ||
| ) |
Collaborator
There was a problem hiding this comment.
will we need to maintain this list whenever codex updates their cli ?
lilly-luo
reviewed
Jul 10, 2026
Comment on lines
+448
to
+450
| _CODEX_PROFILE_SUBCOMMANDS = frozenset( | ||
| {"exec", "review", "resume", "archive", "delete", "unarchive", "fork", "mcp", "sandbox"} | ||
| ) |
Collaborator
There was a problem hiding this comment.
will we also need to maintain this list ? it also will depend on the cli version of codex that the customer is on
Collaborator
Author
There was a problem hiding this comment.
yes, I can't see how we can get around this. but problem statement is ucode unconditionally adds --profile to all codex commands when codex doesn't support --profile on all subcommands. do you have any ideas?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ucode codex's launch always rancodex --profile ucode <args>. But codex only accepts the global--profileon runtime subcommands (the interactive TUI,exec/review/resume/archive/delete/unarchive/fork/mcp/sandbox). Server-family subcommands (app-server,mcp-server,exec-server,remote-control) and utilities reject it immediately:So
ucode codex app-server(and the other server subcommands) was functionally broken.Change
--profile(a deny-list would break the next codex server subcommand by default; the allow-list fails safe) and attach it only for those.--profileand pass the caller's args through untouched. Those are caller-configured — omnigent runscodex app-serverwith its ownCODEX_HOME, and ucode's config isn't even read whenCODEX_HOMEis set — so ucode just stays out of the way rather than injecting a named profile codex won't accept.Scoped to the minimum: just the
--profileguard in the codex agent (_codex_subcommand+ the allow-list). No config-override machinery, no passthrough.Verification
ruff+tyclean.codex app-server --listen …(no--profile) binds cleanly.codex --profile ucode execstill works (runtime subcommand).codex app-server --profile ucodereproduces the original error (negative control).This pull request and its description were written by Isaac.